Add xml-apis:xml-apis as parentFirstArtifact to io.quarkus:quarkus-core #12945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we definitely want this parentFirst artifact in the core or perhaps only in the kubernetes extension where the problem was reported? |
|
Right, it could be moved to the kubernetes one instead to fix the reported use-case. I added it to the core to potentially fix similar issues for other extensions. |
|
I'm fine with it either way. @stuartwdouglas WDYT? |
|
Maybe it can fix this one as well : #7359 ? |
|
@sberyozkin I can reproduce the issue you referenced with 1.9.0.FInal but not the current master. |
|
@aloubyansky this is a nice surprise :-), let me try it too :-) |
|
@aloubyansky Thanks Alexey, I wish more open issues will get self-resolved like this :-) |
|
If it's a global fix, it should be in core. |
stuartwdouglas
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue reported in https://groups.google.com/g/quarkus-dev/c/_Cs-ga4zsWM/m/ZMZAIhCjBgAJ
Fixes #7359