Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that k8s integration tests don't use locally configured cluster #12932

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Ensure that k8s integration tests don't use locally configured cluster #12932

merged 1 commit into from
Oct 26, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Oct 26, 2020 •
edited
Loading

Fixes: #12915

@geoand geoand requested a review from gsmet October 26, 2020 06:39
@iocanel iocanel self-requested a review October 26, 2020 10:52
iocanel
iocanel requested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a comment explaining the reasoning would help in the future.
ATM, its obvious but I am not sure if it will be a couple of months in.

@geoand
Copy link
Contributor Author

geoand commented Oct 26, 2020

Makes sense. Comment added

@geoand geoand requested a review from iocanel October 26, 2020 11:37
iocanel
iocanel approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit 472dbd3 into quarkusio:master Oct 26, 2020
@geoand geoand deleted the #12915 branch October 26, 2020 15:06
@geoand geoand mentioned this pull request Oct 27, 2020
Closed
@gsmet gsmet added this to the 1.10 - master milestone Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iocanel iocanel iocanel approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0.CR1
Development

Successfully merging this pull request may close these issues.

Kubernetes Invoker tests deploy to OpenShift cluster if logged in
3 participants
@geoand @iocanel @gsmet