feat: Introduce 3.x and 4.x style of openshift manifests. #12884
Conversation
|
fyi: @gsmet: we discussed about it on zulip. |
| import io.quarkus.test.ProdModeTestResults; | ||
| import io.quarkus.test.QuarkusProdModeTest; | ||
|
|
||
| public class OpenshiftV3Test { |
There was a problem hiding this comment.
Can we have a corresponding v4 test?
There was a problem hiding this comment.
V4 is the default, it has not special configuration
There was a problem hiding this comment.
Yeah I know. But do we have a test that asserts the same thing as this test but checks for the v4 conditions?
iocanel
force-pushed
the
openshift-3.x
branch
from
60afd06 to
8662de0
Compare
gastaldi
changed the title
...netes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/OpenshiftConfig.java
Outdated
Show resolved
Hide resolved
iocanel
force-pushed
the
openshift-3.x
branch
from
8662de0 to
300fd2e
Compare
|
@iocanel what's the status for the tests? Are we good? |
|
@gsmet I merged this once I saw tests for v3 and v4, hence why I dismissed your review |
|
Then either you or Ionnis should drop a message please. It's really hard to keep track of things if people just silently do things. Thanks. |
|
Will do, but rest assured that I always check if all concerns are resolved before merging a PR (well most of the time :)) |
This pull request introduces
quarkus.openshift.flavorwhich supports values:v3andv4(default).Based on the specified value:
3.x
appwhich is needed by the openshift console.