Extract gRPC common stuff #12860
Merged
Extract gRPC common stuff #12860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
feat/extract-grpc
branch
2 times, most recently
from
1415705 to
6ebd7ec
Compare
|
@gsmet I fixed the pom issues, sorry about that I forget to add names and check the poms before pushing it. |
gsmet
approved these changes
Oct 22, 2020
|
Things are good from my point of view but I will let @cescoffier and @michalszynkiewicz approve and merge it. |
gsmet
previously requested changes
Oct 22, 2020
loicmathieu
force-pushed
the
feat/extract-grpc
branch
from
6ebd7ec to
c6e7129
Compare
michalszynkiewicz
approved these changes
Oct 22, 2020
michalszynkiewicz
dismissed
gsmet’s stale review
the change request has been addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12602
This externalize the gRPC dependency management and native image stuff so it can be share with the Quarkiverse Google Cloud Services extension.