Optimize OIDC code flow to do one less redirect when the original path has to be restored #12857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OIDC
CodeAuthenticationMechanism
can restore the original request path, for example:GET /web-app/service
/web-app
/web-app
/web-app/service
thus restoring the original request URI; to implement it, a custompathChecked
query is added, so it is not idealcode
andstate
and other non-custom query parametersSo, step 4 is redundant, it adds to the cost of processing and also returns
code
andstate
back to the browser because the code flow has not completed yet.As such this PR drops step 4 and the original path, if needed, will be restored as part of the last step
I had to fix a few tests because they were written around the flow involving step4.