Check Reactive Redis Client for healthcheck #12833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Oct 22, 2020
| for (InstanceHandle<ReactiveRedisClient> handle : Arc.container() | ||
| .select(ReactiveRedisClient.class, Any.Literal.INSTANCE).handles()) { | ||
| String clientName = getClientName(handle.getBean()); | ||
| reactiveClients.put(clientName == null ? DEFAULT_CLIENT : clientName, handle.get()); |
There was a problem hiding this comment.
So we're not exactly on par with the MongoDB impl here where the name of the default reactive client is different?
There was a problem hiding this comment.
My reason was to produce healthcheck status for each individual redis client without caring much whether that was done with a reactive client or a blocking one (as it does not matter much).
There was a problem hiding this comment.
I think we should be consistent but that can probably be done in another PR.
Merging.
machi1990
force-pushed
the
review-redis-healthcheck
branch
from
7ada742 to
3c43871
Compare
gsmet
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up #12781 (comment)
/cc @gsmet