Add oidc-wiremock to CI Security2 category #12822
Merged
+11
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machi1990
approved these changes
Oct 20, 2020
|
@machi1990 So it failed, though I've confirmed it works in the native image for me, hmm... need to find the logs somehow :-) |
|
Right, so it is since Keycloak is listening there as well, elytron oauth2 tests run on the default 8080 port, so I'll try it |
sberyozkin
force-pushed
the
add_oidc_wiremock_test_to_ci
branch
from
6ef8375 to
1297006
Compare
gastaldi
reviewed
Oct 20, 2020
| WireMock.stubFor( | ||
| get(urlEqualTo("/auth/realms/quarkus/.well-known/openid-configuration")) | ||
| .willReturn(aResponse() | ||
| .withHeader("Content-Type", MediaType.APPLICATION_JSON) | ||
| .withBody("{\n" + | ||
| " \"authorization_endpoint\": \"http://localhost:8180/authenticate\",\n" + | ||
| " \"end_session_endpoint\": \"http://localhost:8180/logout\",\n" + | ||
| " \"authorization_endpoint\": \"http://localhost:8080/authenticate\",\n" + |
There was a problem hiding this comment.
Another option would be to use server.getOptions().portNumber()
There was a problem hiding this comment.
@gastaldi @machi1990 it also has server.baseUrl() so I've used it and also removed the redundant discovery values which are not needed for the mock testing; it should be very easy for the users to mock the bearer token authentication; code flow would have something more similar to the original, CC @cemnura
sberyozkin
force-pushed
the
add_oidc_wiremock_test_to_ci
branch
from
1297006 to
3f1fa17
Compare
gastaldi
approved these changes
Oct 20, 2020
sberyozkin
force-pushed
the
add_oidc_wiremock_test_to_ci
branch
from
3f1fa17 to
4b7d6c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also move
elytron-resteasyto theHTTPcategory where all other resteasy tests are run