Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/doc and test traced #12791

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

loicmathieu
Copy link
Contributor

Add @Traced to the documentation. It exists in the quickstart so it's worth mentioning it inside the guide.

Update the main integration test to use @Traced in another bean as the REST endpoint is traced by default and it reflect the typical usage of @Traced.

@loicmathieu loicmathieu requested a review from Ladicek October 19, 2020 12:27
@loicmathieu loicmathieu force-pushed the feat/doc-and-test-traced branch from 21fec3b to 8e10ec0 Compare October 19, 2020 15:21
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be nice to squash before merging these commits 👍

@loicmathieu
Copy link
Contributor Author

@gastaldi I applied your suggestions

@loicmathieu
Copy link
Contributor Author

@gastaldi I keep two commits as they are unrelated changes: documentation and test enhancement

@gastaldi
Copy link
Contributor

@loicmathieu cool, maybe the commit with my suggestion can be squashed into the first commit then 😉

@loicmathieu
Copy link
Contributor Author

@loicmathieu cool, maybe the commit with my suggestion can be squashed into the first commit then 😉

Already done, I always squashed suggestion commits a few seconds/minutes after commiting them, you was too hurry ;)

@gastaldi gastaldi added this to the 1.10 - master milestone Oct 19, 2020
@gastaldi gastaldi merged commit 6f4e3b3 into quarkusio:master Oct 19, 2020
@gastaldi
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants