Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use counter for JVM Info #12699

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Use counter for JVM Info #12699

merged 1 commit into from
Oct 14, 2020

Conversation

ebullient
Copy link
Member

Use a counter instead of a gauge to avoid NaN from GC.

Resolves #12694

gastaldi
gastaldi approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been able to reproduce the error described in the issue and I can confirm this PR works as advertised.

Good job! 👍

@gastaldi gastaldi added this to the 1.10 - master milestone Oct 14, 2020
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2020
@gastaldi gastaldi merged commit 170f609 into quarkusio:master Oct 14, 2020
@ebullient ebullient deleted the jvm-info branch October 14, 2020 03:44
@gsmet gsmet modified the milestones: 1.10 - master, 1.9.0.Final Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.9.0.Final
3 participants
@ebullient @gastaldi @gsmet