Allow custom path and class for spring-web codestart #12684
Conversation
- Make sure that custom `path` and `className` are ignored when resteasy is selected (to avoid conflicts) - Add tests Fixes quarkusio#12604
gsmet
force-pushed
the
fix-spring-web-codestart
branch
from
91c3d16 to
bce82a5
Compare
|
Rebased to get a CI fix. |
|
Oups, what about the check failed? |
@aureamunoz we can ignore it's a network problem: |
|
I will re-run the CI anyway, I don't like to merge when the CI failed.. |
|
@aloubyansky could you review that one please :) |
| if (containsRESTEasy(extensions)) { | ||
| values.remove(CLASS_NAME); | ||
| values.remove(PACKAGE_NAME); | ||
| values.remove(RESOURCE_PATH); |
There was a problem hiding this comment.
I assume that's necessary but it's not clear why. In case of Spring these props aren't relevant? Are they still relevant for RESTEasy?
There was a problem hiding this comment.
@aloubyansky there is another if (containsSpringWeb(extensions)) { just before, so if we have resteasy and spring we don't use those because it would means that the spring resources and the resteasy one will have the same path and class name, we don't want that :)
There was a problem hiding this comment.
if you have just resteasy or spring then there is no problem :)
There was a problem hiding this comment.
Are these CLASS_NAME, etc used in case of Spring web at all? How is the class name passed for spring?
pathandclassNameare ignored when resteasy is selected (to avoid conflicts)Fixes #12604