Externalize gradle/maven wrapper command from codestart template

[glefloch]

This branch aims to externalize the build tool command used in the generated github action workflow.

@ia3andy I added a field build-cmd which could be used by all command such as:

cmd:
      dev: ${buildtool.cmd.build-cmd} compile quarkus:dev
      package: ${buildtool.cmd.build-cmd} package

But I don't know if this is the goal.

also, I don't how to test if my code is correct, could you give me pointers to validate it ? thanks :)

close #12438

[ia3andy]

@glefloch that's not a bad idea, but it means you have to update all the different commands (and usage), but it would save us from overriding all the different commands where the arguments are the same..

For the GitHub Action issue, the problem is with the CI container which need to include either mvn or gradle.. I guess, instead of having a wrapper data, we could have a new shared-data named container-image or something (that we override in the wrapper).. problem then is with java version..

I let you figure out the best solution :)

[glefloch]

ah ok, I get you mean for action, in fact, if you don't use the wrapper, you need the right github action. I will update my branch.

I just have another quick question, who does edit this file? Is that generated from https://code.quarkus.io/ ?

[ia3andy]

@glefloch for now, it's used by code.quarkus.io (https://github.com/quarkusio/code.quarkus.io/blob/master/src/main/kotlin/io/quarkus/code/service/QuarkusProjectService.kt#L58) when github is picked (and always with the wrappers) so no problem. We don't have code for now that uses github action without the wrapper, but the CreateProject allows it..

[glefloch]

@ia3andy, I added some test to assert the condition. Regarding maven, it seems to be available by default on ubuntu-latest nodes. we just have to handle the gradle part.

[ia3andy]

I added a few simplification ideas 👆

[ia3andy]

@glefloch and thanks for doing this :)

[glefloch]

@ia3andy I updated the branch with the changes we discussed.

[ia3andy]

beside build-ci-args it looks good :)

[ia3andy]

@glefloch you will need to resolve the conflict introducted by: #12700

Sorry I had to merge it first as it will need to be backported..

[ia3andy]

@glefloch we will also need to wait for: #12707

[glefloch]

ok no problem

[ia3andy]

Well done!