-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added detailed for deploying to OpenShift and how to test the app #12590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, but to be completely honest, I don't see it bringing much to the table for new users.
@gastaldi WDYT?
@geoand I'm afraid I personally don't have any opinion on this, so I'll let you to decide 😉 |
👍 |
Hi @geoand thanks for reaching out to @gastaldi for a second opinion. The instructions for deploying to OpenShift in this document did not work for me. It would be worthwhile if you could get another person to test them to see if he or she could follow the document and deploy the application to OpenShift. I only worked out how to use the openshift.json as suggested here to deploy the application to OpenShift after I had learnt how to deploy to OpenShift from the "Deploying to OpenShift" document and did a fair amount of trial and error. From my experience, I found that the following key details are missing from this document:
With those changes, the deployment command |
@iocanel what's your take on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@iocanel I'll let you merge if you like this since I am +0 on this one. |
@geoand: why are you reluctant? Anything I may have missed? |
It's just that I don't see it adding much value, but I might be to used to the whole process. |
Relating to issue #11730 and complement PR #12356
Hi @geoand, further to the completion of PR 12356 which improves "Deploying to OpenShift" document, I raise this PR to improve the OpenShift deployment section of the "Deploying to Kubernetes" document and also link it to the "Deploying to OpenShift" document. I hope this would help other developers to avoid the difficulties that I encountered when I first tried to following the instructions in the "Deploying to Kubernetes" document. Jack