Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added detailed for deploying to OpenShift and how to test the app #12590

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

jackhu008
Copy link
Contributor

@jackhu008 jackhu008 commented Oct 7, 2020

Relating to issue #11730 and complement PR #12356

Hi @geoand, further to the completion of PR 12356 which improves "Deploying to OpenShift" document, I raise this PR to improve the OpenShift deployment section of the "Deploying to Kubernetes" document and also link it to the "Deploying to OpenShift" document. I hope this would help other developers to avoid the difficulties that I encountered when I first tried to following the instructions in the "Deploying to Kubernetes" document. Jack

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, but to be completely honest, I don't see it bringing much to the table for new users.

@gastaldi WDYT?

@gastaldi
Copy link
Contributor

gastaldi commented Oct 8, 2020

@geoand I'm afraid I personally don't have any opinion on this, so I'll let you to decide 😉

@geoand
Copy link
Contributor

geoand commented Oct 8, 2020

👍

@jackhu008
Copy link
Contributor Author

jackhu008 commented Oct 8, 2020

Hi @geoand thanks for reaching out to @gastaldi for a second opinion. The instructions for deploying to OpenShift in this document did not work for me. It would be worthwhile if you could get another person to test them to see if he or she could follow the document and deploy the application to OpenShift.

I only worked out how to use the openshift.json as suggested here to deploy the application to OpenShift after I had learnt how to deploy to OpenShift from the "Deploying to OpenShift" document and did a fair amount of trial and error. From my experience, I found that the following key details are missing from this document:

  • remove kubernetes and jib dependencies from the pom.xml - by running the command ./mvnw quarkus:remove-extension -Dextensions="kubernetes, jib"

  • add openshift as depdency ./mvnw quarkus:add-extension -Dextensions="openshift"

  • add the build extension in the "./mvnw clean package" command, i.e. ./mvnw clean package -Dquarkus.container-image.build=true

With those changes, the deployment command oc apply -f target/kubernetes/openshift.json would work.

@geoand
Copy link
Contributor

geoand commented Oct 9, 2020

@iocanel what's your take on this?

@iocanel iocanel self-requested a review October 13, 2020 09:01
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand
Copy link
Contributor

geoand commented Oct 13, 2020

@iocanel I'll let you merge if you like this since I am +0 on this one.

@iocanel
Copy link
Contributor

iocanel commented Oct 13, 2020

@geoand: why are you reluctant? Anything I may have missed?

@geoand
Copy link
Contributor

geoand commented Oct 13, 2020

It's just that I don't see it adding much value, but I might be to used to the whole process.

@gastaldi gastaldi merged commit 64e2b63 into quarkusio:master Oct 13, 2020
@gastaldi gastaldi added this to the 1.10 - master milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants