Change default media type to JSON #12566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
defaut-json
branch
2 times, most recently
from
81122f3 to
18456a9
Compare
Ladicek
reviewed
Oct 8, 2020
stuartwdouglas
force-pushed
the
defaut-json
branch
5 times, most recently
from
6dd7000 to
ed67977
Compare
gsmet
previously requested changes
Oct 12, 2020
| @Produces(MediaType.WILDCARD) | ||
| @Consumes(MediaType.WILDCARD) | ||
| @Priority(Priorities.USER - 200) | ||
| public class QuarkusJSONBSerializer extends JsonBindingProvider { |
There was a problem hiding this comment.
Should be called QuarkusJsonbSerializer for consistency with other classes.
| @@ -0,0 +1,77 @@ | |||
| package io.quarkus.resteasy.jsonb; | |||
There was a problem hiding this comment.
It's not API so it should be in the runtime package.
This adds a new RESTEasy provider that will produce JSON by default. This removes the need to add @produces(MediaType.APPLICATION_JSON) and @consumes(MediaType.APPLICATION_JSON) everywhere. The old behaviour can be retained by setting: quarkus.resteasy-json.default-json=false in application.properties.
stuartwdouglas
force-pushed
the
defaut-json
branch
from
ed67977 to
f0a4c7c
Compare
|
Done |
gastaldi
approved these changes
Oct 13, 2020
|
@stuartwdouglas apparently this PR does not support this: @GET
public Map<String,String> hello() {
Map<String,String> t = new HashMap<>();
t.put("Hey", "Ho");
return t;
}I get the following error while hitting the endpoint: |
|
I created #12701 |
|
Ignore it, I forgot to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new RESTEasy provider that will produce
JSON by default. This removes the need to add
@produces(MediaType.APPLICATION_JSON) and
@consumes(MediaType.APPLICATION_JSON) everywhere.
The old behaviour can be retained by setting:
quarkus.resteasy-json.default-json=false
in application.properties.