Ability to handle both exit code and exception when running CLI applications #12532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroigor
force-pushed
the
issue-12397
branch
3 times, most recently
from
ac593bf to
9547028
Compare
stuartwdouglas
requested changes
Oct 7, 2020
core/runtime/src/main/java/io/quarkus/runtime/ApplicationLifecycleManager.java
Outdated
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/ApplicationLifecycleManager.java
Outdated
Show resolved
Hide resolved
stuartwdouglas
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12397
A few points:
Applicationso that any logging can be done depending on whether or not an exit handler is provided.I'm not sure if that is the best approach but it helps to allow CLI applications to better handle messages to their users without necessarily show Quarkus messages and stack traces.