-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Tika 1.24.1 #12506
Update to Tika 1.24.1 #12506
Conversation
Before the rebase yesterday it was ok, but I did not rebuild after the final rebase... |
ca3f7ab
to
3ec123f
Compare
Sorry it was probably a broken test, I was focusing on the |
7c2e480
to
faa5650
Compare
hi @sberyozkin , did you try the subtitution? It would be preferrable over adding |
@sberyozkin : this substitution should work? |
2b110ac
to
1eeb0c1
Compare
@Sanne thanks for your help, I'll now be looking for the opportunity to write the substitutions everywhere :-). |
|
1eeb0c1
to
c99e846
Compare
c99e846
to
80da637
Compare
@gsmet Hi, this PR got a bit unlucky as I was hoping to merge it yesterday :-) but I'll target 1.10 now I guess and will add a backport label |
I had to add
--report-unsupported-elements-at-runtime
to bypass an Apache POI issue I commented at:see #6549 (comment)
and in Zulip, https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Native.20issue.
This is not introducing any new issues since Apache POI does not currently work in the native mode (#6549)