Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Tika 1.24.1 #12506

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Update to Tika 1.24.1 #12506

merged 1 commit into from
Oct 7, 2020

Conversation

sberyozkin
Copy link
Member

I had to add --report-unsupported-elements-at-runtime to bypass an Apache POI issue I commented at:
see #6549 (comment)
and in Zulip, https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/Native.20issue.
This is not introducing any new issues since Apache POI does not currently work in the native mode (#6549)

@sberyozkin sberyozkin requested a review from gsmet October 4, 2020 17:00
@sberyozkin
Copy link
Member Author

ANTLR Tool version 4.7.2 used for code generation does not match the current runtime version 4.8ANTLR Tool version 4.7.2 used for code generation does not match the current runtime version 4.8ANTLR Tool version 4.7.2 used for code generation does not match the current runtime version 4.8ANTLR Tool version 4.7.2 used for code generation does not match the current runtime version 4.8

Before the rebase yesterday it was ok, but I did not rebuild after the final rebase...

@sberyozkin
Copy link
Member Author

Sorry it was probably a broken test, I was focusing on the integration-tests/tika so was rebuilding by skipping the tests

@sberyozkin sberyozkin force-pushed the tika_1.24.1 branch 3 times, most recently from 7c2e480 to faa5650 Compare October 6, 2020 09:20
@Sanne
Copy link
Member

Sanne commented Oct 6, 2020

hi @sberyozkin , did you try the subtitution? It would be preferrable over adding --report-unsupported-elements-at-runtime, as it would hide any other problems; we risk having all of Tika entirely broken for all users, rather than "just" POI.

@Sanne
Copy link
Member

Sanne commented Oct 6, 2020

@sberyozkin : this substitution should work?

@Sanne Sanne requested review from Sanne and removed request for gsmet October 6, 2020 15:14
@sberyozkin
Copy link
Member Author

@Sanne thanks for your help, I'll now be looking for the opportunity to write the substitutions everywhere :-).

@sberyozkin
Copy link
Member Author

GraphQLTest.testSchema:50 expected: <true> but was: <false> on Win, I'll give it another try

@sberyozkin
Copy link
Member Author

@gsmet Hi, this PR got a bit unlucky as I was hoping to merge it yesterday :-) but I'll target 1.10 now I guess and will add a backport label

@sberyozkin sberyozkin merged commit cedceb3 into quarkusio:master Oct 7, 2020
@sberyozkin sberyozkin deleted the tika_1.24.1 branch October 7, 2020 17:51
@gsmet gsmet added this to the 1.9.0.Final milestone Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants