Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create RESTEasy Jackson codestart #12494

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

jantosi
Copy link
Contributor

@jantosi jantosi commented Oct 3, 2020

This is provided instead of #12341 - rebased commits.

@ia3andy
Copy link
Contributor

ia3andy commented Oct 5, 2020

@jantosi you don't need to create a new PR when rebasing :), rebase locally, then use git push jantosi --force-with-lease

Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing on gradle, I added comments on the reason..

@@ -0,0 +1,9 @@
package org.acme.rest.json;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to move the native test to src/native-test/java/org/acme/rest/json/NativeFruitResourceIT.java, this is a gradle specificity (for maven the file will be automatically moved to the test directory), maybe we need to add this to the doc..

@@ -0,0 +1,6 @@
package org.acme.rest.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other, you need to move the native test.

@@ -8,6 +8,8 @@ This guide explains how to create and configure a Quarkus Codestart for an exten
Codestarts provide a personalized Quarkus getting started experience and really show the Quarkus breadth.
A Quarkus extension are able to provide one or more well defined codestarts which will contain the necessary resources and code examples required to get started using that particular extension.

See the staging environment to get an understanding what new quickstarts are: https://stage.code.quarkus.io/[https://stage.code.quarkus.io/]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can point to code.quarkus.io directly in the doc, I will promote staging to production later today..

@jantosi jantosi force-pushed the resteasy-json-codestart branch 2 times, most recently from ac224e4 to f36944e Compare October 10, 2020 02:08
@jantosi jantosi force-pushed the resteasy-json-codestart branch from f36944e to 67dca28 Compare October 10, 2020 05:54
@jantosi
Copy link
Contributor Author

jantosi commented Oct 10, 2020

Pushed a simple change to trigger the build again - JVM core-dumped:
https://github.com/quarkusio/quarkus/runs/1234266259?check_suite_focus=true#step:6:70362

@jantosi jantosi requested a review from ia3andy October 10, 2020 05:56
Copy link
Contributor

@ia3andy ia3andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ia3andy ia3andy added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 10, 2020
@ia3andy
Copy link
Contributor

ia3andy commented Oct 10, 2020

In another PR, we will need to update the guide: #12642

@ia3andy ia3andy merged commit 84cc29e into quarkusio:master Oct 12, 2020
@gsmet gsmet added this to the 1.10 - master milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants