Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codestarts as default project generation tool #12473

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Oct 2, 2020

  • Codestarts which only works alone are called "Singleton"
  • Added checks to avoid conflict between Singelton codestarts
  • Make codestart the default codegen and add a legacyCodegen flag
  • Use RESTEasy example as default (commandmode example is not selectable for now.. until a picocli Create the Picocli Example codestart in Java & Kotlin #12633 example?)
  • Update the guides with -DnoExamples when when relevent
  • Update the tests

Fixes #12113

@ia3andy ia3andy force-pushed the codestarts-up4 branch 2 times, most recently from 55cbe48 to e1758f8 Compare October 2, 2020 10:53
@ia3andy ia3andy changed the title Singleton codestarts Codestarts as default codegen Oct 2, 2020
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 2, 2020

cc @maxandersen that gives you an idea of the PR

@ia3andy ia3andy added this to the 1.9.0 - master milestone Oct 2, 2020
@ia3andy ia3andy force-pushed the codestarts-up4 branch 5 times, most recently from 6c661d1 to d6c6b86 Compare October 6, 2020 14:01
@gsmet gsmet removed this from the 1.9.0.CR1 - master milestone Oct 7, 2020
@ia3andy ia3andy force-pushed the codestarts-up4 branch 2 times, most recently from b53cc83 to a65e293 Compare October 7, 2020 18:12
@ia3andy ia3andy marked this pull request as ready for review October 8, 2020 06:20
@aloubyansky
Copy link
Member

Update the guides for compat by adding resteasy when relevent

What kind of compatibility? I understand that the plain resteasy extension isn't added in many cases now. My question is what kind of issue does it create?

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 8, 2020

Update the guides for compat by adding resteasy when relevent

What kind of compatibility? I understand that the plain resteasy extension isn't added in many cases now. My question is what kind of issue does it create?

Some of our guides instruction are based on the resteasy example, thus without it in the command extensions, it is not generated. Soon, we will have example for most extensions, then we will have to remove resteasy, and the example will directly be the appropriate one.. (like we just did with spring-web)

@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 9, 2020

I am waiting for the result of this discussion to make the decided changes: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/quarkus-dev/-j7C9UqYbF4/qyiTzQU5AAAJ

- Codestarts which only works alone are called "Singleton"
- Added checks to avoid conflict between Singelton codestarts
- Make codestart the default codegen and add a legacyCodegen flag
- Use RESTEasy example as default (commandmode example is not selectable for now.. until a picocli example?)
- Update the guides with `-DnoExamples` when when relevent
- Update the tests

Fixes quarkusio#12113
@ia3andy
Copy link
Contributor Author

ia3andy commented Oct 12, 2020

Sorry @aloubyansky this will need to be reviewed again. Since your approval, I've set resteasy as default and updated the docs and tests accordingly..

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ia3andy ia3andy merged commit b035425 into quarkusio:master Oct 12, 2020
@ia3andy ia3andy deleted the codestarts-up4 branch October 12, 2020 17:49
@gsmet gsmet added this to the 1.10 - master milestone Oct 13, 2020
@gsmet gsmet changed the title Codestarts as default codegen Use Codestarts as default project generation tool Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activate Codestart as the default Quarkus project creation option
4 participants