-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Codestarts as default project generation tool #12473
Conversation
55cbe48
to
e1758f8
Compare
cc @maxandersen that gives you an idea of the PR |
6c661d1
to
d6c6b86
Compare
b53cc83
to
a65e293
Compare
...cts/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/CodestartProjectInput.java
Show resolved
Hide resolved
What kind of compatibility? I understand that the plain resteasy extension isn't added in many cases now. My question is what kind of issue does it create? |
Some of our guides instruction are based on the resteasy example, thus without it in the command extensions, it is not generated. Soon, we will have example for most extensions, then we will have to remove resteasy, and the example will directly be the appropriate one.. (like we just did with spring-web) |
I am waiting for the result of this discussion to make the decided changes: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/quarkus-dev/-j7C9UqYbF4/qyiTzQU5AAAJ |
6d500ce
to
a1ed695
Compare
a1ed695
to
ceeda36
Compare
- Codestarts which only works alone are called "Singleton" - Added checks to avoid conflict between Singelton codestarts - Make codestart the default codegen and add a legacyCodegen flag - Use RESTEasy example as default (commandmode example is not selectable for now.. until a picocli example?) - Update the guides with `-DnoExamples` when when relevent - Update the tests Fixes quarkusio#12113
ceeda36
to
ecb8550
Compare
Sorry @aloubyansky this will need to be reviewed again. Since your approval, I've set resteasy as default and updated the docs and tests accordingly.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
-DnoExamples
when when releventFixes #12113