Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing jsr305 as dependency to verify if the grpc extension works fine without it #12314

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

harshmadhani
Copy link
Contributor

Removing jsr305 as dependency to verify if the grpc extension works fine

@michalszynkiewicz
Copy link
Member

@cescoffier it seems it works fine ;)

@harshmadhani
Copy link
Contributor Author

@cescoffier would we still require jsr305 as a dependency in grpc runtime if the checks are passed for them without jsr305?

@cescoffier
Copy link
Member

@harshmadhani If we can remove it, let's remove it!

@harshmadhani
Copy link
Contributor Author

Thanks, @cescoffier !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants