Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gradle buildscript test in integration test project #12259

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

glefloch
Copy link
Member

As mentioned in zulipchat (https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/CI.20Failure/near/210860140), the job is failing due to failed test in the gradle plugin project.

Those tests require the plugin to be installed which is not the case at that moment in the job.

As for the builder test, this branch just move those tests in the integration-test/gradle project.
I thinkg this should fix the issue with the snapshot job.

Is there a way to run it locally @geoand, @aloubyansky ?

@geoand
Copy link
Contributor

geoand commented Sep 22, 2020

Thanks for this!

Are you asking if we can the job locally? I don't think you can.

But if CI passes here, I see no reason to not merge and see how the job reacts.

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just doing the same change. Thanks @glefloch!

@aloubyansky aloubyansky added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 22, 2020
@geoand geoand added this to the 1.9.0 - master milestone Sep 22, 2020
@gastaldi gastaldi merged commit ddf0357 into quarkusio:master Sep 23, 2020
@glefloch glefloch deleted the fix/ci-snapshot-job branch September 23, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants