Support for combining OIDC with other auth mechanisms #11937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #11886.
This PR fixes a minor issue in the OIDC code (returning 'null' token credentials when no token is available) to have the OIDC service authentication combined with the other auth mechanims (basic, etc). Note I've updated the test and changed
Principal
toSecurityIdentity
- this is becausesmallrye-jwt
ships a (JsonWebToken)Principal
producer and, with the basic auth, it returns a null name.@gsmet I think it is a bug fix, but it is not an urgent fix as some more work needs to be done around #11886, hence not adding a backport label