Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn StartupBuildSteps.annotationTransformer() into an AutoAddScopeBuildItem #11708

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Turn StartupBuildSteps.annotationTransformer() into an AutoAddScopeBuildItem #11708

merged 1 commit into from
Aug 31, 2020

Conversation

manovotn
Copy link
Contributor

…ildItem.

Fixes #11700

@manovotn manovotn requested a review from mkouba August 28, 2020 11:08
@boring-cyborg boring-cyborg bot added the area/arc Issue related to ARC (dependency injection) label Aug 28, 2020
@manovotn
Copy link
Contributor Author

@mkouba I have addressed the other two comments. Let me know if you want me to change the transformer to also apply to methods, but I think it's unintentional. Alternatively, we can OFC introduce a new helper method for just class-level annotations.

@manovotn manovotn requested a review from mkouba August 31, 2020 08:01
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 31, 2020
@mkouba mkouba added this to the 1.8.0 - master milestone Aug 31, 2020
@gsmet gsmet changed the title Turn StartupBuildSteps.annotationTransformer() into an AutoAddScopeBu… Turn StartupBuildSteps.annotationTransformer() into an AutoAddScopeBuildItem Aug 31, 2020
@gsmet gsmet merged commit 02c274c into quarkusio:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.8.0.CR1
Development

Successfully merging this pull request may close these issues.

Turn StartupBuildSteps.annotationTransformer() into an AutoAddScopeBuildItem
3 participants
@manovotn @mkouba @gsmet