Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Ddocker option to spin a Redis Server container automatically when launching Redis IT test #11686

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Add -Ddocker option to spin a Redis Server container automatically when launching Redis IT test #11686

merged 1 commit into from
Aug 27, 2020

Conversation

machi1990
Copy link
Member

No description provided.

@machi1990 machi1990 changed the title chore(redis): add -Ddocker option to spin a Redis Server container automatically when launching test Add -Ddocker option to spin a Redis Server container automatically when launching Redis IT test Aug 27, 2020
@machi1990 machi1990 requested review from gsmet and geoand August 27, 2020 20:12
@machi1990 machi1990 mentioned this pull request Aug 27, 2020
Merged
gsmet
gsmet approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works perfectly, thanks!

@gsmet gsmet added this to the 1.8.0 - master milestone Aug 27, 2020
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 27, 2020
@gsmet
Copy link
Member

gsmet commented Aug 27, 2020

The JDK 11 build passed, it's good enough for this change.

@gsmet gsmet merged commit c88263e into quarkusio:master Aug 27, 2020
@machi1990 machi1990 deleted the chore/add-docker-option branch August 27, 2020 21:16
@gsmet gsmet added area/infra internal and infrastructure related issues triage/backport? and removed area/infra internal and infrastructure related issues labels Sep 1, 2020
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.2.Final Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/redis triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.2.Final
Development

Successfully merging this pull request may close these issues.
3 participants
@machi1990 @gsmet @geoand