-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codestart customized package and class and more #11668
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area/devtools
Issues/PR related to maven, gradle, platform and cli tooling/plugins
label
Aug 27, 2020
ia3andy
force-pushed
the
codestarts-up3
branch
2 times, most recently
from
August 27, 2020 15:18
812545a
to
8e0272c
Compare
ia3andy
force-pushed
the
codestarts-up3
branch
from
August 27, 2020 15:52
8e0272c
to
f6f959f
Compare
ia3andy
force-pushed
the
codestarts-up3
branch
from
August 28, 2020 05:47
f6f959f
to
51545e8
Compare
ia3andy
force-pushed
the
codestarts-up3
branch
from
August 28, 2020 06:21
51545e8
to
50f121a
Compare
The native tests are all passing on my fork CI. |
I don't think I am going to have everything ready to have Codestarts default in 1.8 CR1, missing:
@maxandersen @gsmet this will not be large PRs, maybe they can come in the next release? |
FYI with this PR, we don't have to change the doc. |
@quarkusio/devtools this PR is quite urgent as it targets 1.8.0 |
aloubyansky
reviewed
Aug 31, 2020
...t-projects/tools/codestarts/src/test/java/io/quarkus/devtools/codestarts/CodestartsTest.java
Show resolved
Hide resolved
aloubyansky
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11154
/{package-name.dir}/{my-class-key}.java
which will be filled with data (my-package-name.dir
will look formy-package-name
and transform it to directory path).resteasy-example.resource.class-name
to define local dataresource.class-name
). Shared data still doesn't need a prefix.devtools-common
and made that part cleaner using a builderresteasy-example
andcommandmode-example
-Dpath
and-DclassName
from Maven plugin to codestarts