Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codestart customized package and class and more #11668

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Aug 27, 2020

Fixes #11154

  • Add dynamic path support to codestart structure, ex: /{package-name.dir}/{my-class-key}.java which will be filled with data (my-package-name.dir will look for my-package-name and transform it to directory path).
  • local codestart data is now only overridable by input data prefixed with codestart name (ex: resteasy-example.resource.class-name to define local data resource.class-name). Shared data still doesn't need a prefix.
  • Extract all "Quarkus Project" related logic to devtools-common and made that part cleaner using a builder
  • Use dynamic paths in resteasy-example and commandmode-example
  • Plug -Dpath and -DclassName from Maven plugin to codestarts
  • Added tests for all this

@boring-cyborg boring-cyborg bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Aug 27, 2020
@ia3andy ia3andy force-pushed the codestarts-up3 branch 2 times, most recently from 812545a to 8e0272c Compare August 27, 2020 15:18
@ia3andy ia3andy marked this pull request as ready for review August 27, 2020 18:26
@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 28, 2020

The native tests are all passing on my fork CI.

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 28, 2020

JDK 8 test passed on my local CI and Windows is failing on doc:
image

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 28, 2020

I don't think I am going to have everything ready to have Codestarts default in 1.8 CR1, missing:

  • Add some logging
  • Add Maven plugin logic to make codestart default:
    • default: use codestarts (codestarts with tag compatibility-issues are excluded)
    • --legacy use legacy codegen
    • --codestarts=.. select custom codestarts (allow ones with compatibility-issues)

@maxandersen @gsmet this will not be large PRs, maybe they can come in the next release?

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 28, 2020

FYI with this PR, we don't have to change the doc.

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 31, 2020

@quarkusio/devtools this PR is quite urgent as it targets 1.8.0

@ia3andy ia3andy merged commit 9294c07 into quarkusio:master Aug 31, 2020
@ia3andy ia3andy deleted the codestarts-up3 branch August 31, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codestart dynamic paths for dynamic package names
2 participants