Switch from elasticearch-maven-plugin to docker-maven-plugin to start Elasticsearch for ITs #11599
Conversation
boring-cyborg
bot
added
area/dependencies
yrodiere
changed the title
There was a problem hiding this comment.
Looks good, but in other ITs we make sure to only expect docker if the docker profile is activated. Could you do the same?
Also I think we should adapt the tasks in .github/ actions to pre-start a single ES container for the group. Not sure if that's easy to adapt? Feel free to spin this off as a separate task, as it would be less urgent.
boring-cyborg
bot
added
the
area/infra-automation
|
@Sanne I think I did what you wanted. |
yrodiere
force-pushed
the
i11597
branch
2 times, most recently
from
9e6f7b1 to
94028a6
Compare
|
The build failed, but the failures seem unrelated, and likely transient. I just force-pushed to trigger another build. |
| <goal>exec</goal> | ||
| </goals> | ||
| <configuration> | ||
| <executable>${basedir}/../../.github/docker-prune.sh</executable> |
There was a problem hiding this comment.
Interesting, I just learned about this script.
There was a problem hiding this comment.
I copy-pasted that from another pom file. Not sure it's useful, but well... that's how it works everywhere else 🤷
Changes are picked from quarkusio/quarkus#11599 Closes oracle#2782
Fixes #11597
cc @Sanne @gsmet