Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codestarts testing #11474

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Codestarts testing #11474

merged 1 commit into from
Aug 21, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Aug 19, 2020 •
edited
Loading

Even if I need to keep adding more tests, this should already give a good base with close to 100% coverage of the Codestarts spec and business.

@boring-cyborg boring-cyborg bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Aug 19, 2020
@ia3andy ia3andy marked this pull request as ready for review August 20, 2020 11:41
@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 20, 2020

It also fix a bug found with the tests.

gastaldi
gastaldi previously requested changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the Files.createDirectories exception handling, I think it looks good

...ojects/tools/codestarts/src/main/java/io/quarkus/devtools/codestarts/CodestartProcessor.java Show resolved Hide resolved
...c/main/java/io/quarkus/devtools/codestarts/strategy/ReplaceCodestartFileStrategyHandler.java Show resolved Hide resolved
@ia3andy ia3andy requested a review from gastaldi August 21, 2020 07:08
@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 21, 2020

@gastaldi @maxandersen could you review, I need this merged asap, I have other PRs pending :)

maxandersen
maxandersen approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like "just" test additions and no major surprises. lgtm.

@ia3andy ia3andy merged commit 792e53b into quarkusio:master Aug 21, 2020
@ia3andy ia3andy deleted the codestarts-test branch August 21, 2020 10:40
@geoand geoand added this to the 1.8.0 - master milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen approved these changes

@aloubyansky aloubyansky Awaiting requested review from aloubyansky

@gastaldi gastaldi Awaiting requested review from gastaldi

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Milestone
1.8.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@ia3andy @maxandersen @gastaldi @geoand