Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new builder identity copy method, reverse links to all security docs, client cert example #11446

Merged

Conversation

sberyozkin
Copy link
Member

@sberyozkin sberyozkin commented Aug 18, 2020

This PR:

  • adds the example from Ladislav @Ladicek
  • adds the reverse links from all the security docs to the parent securty.doc
  • adds a new identity builder method to simplify copying the existing identity properties
  • Fixes a link from the code flow SPA section to service SPA section

@Ladicek I'm not marking this PR as the one which provides a fix for #11434, if you think it can be sufficient at this stage then update it

@sberyozkin
Copy link
Member Author

@gastaldi @loicmathieu @gsmet, your comments/reviews are also welcome :-), just would like to avoid formally asking 6 people to review :-)

Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

I'm not sure if this is enough to close the original issue. I don't feel strongly about adding a declarative way of extracting roles from a certificate -- it would be nice, but it's probably not that big of a deal, with documentation in place.

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor documentation changes, otherwise looks good

@sberyozkin
Copy link
Member Author

@Ladicek

I'm not sure if this is enough to close the original issue.

Sure, lets keep the original issue open, the example in the docs would be useful on its own even if/when do something about that issue, as there could always be a situation where some custom certificate processing is required in order to enhance the identity

@sberyozkin
Copy link
Member Author

@gastaldi Perfect editorial updates, thanks :-)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
… docs, client cert example
@sberyozkin sberyozkin force-pushed the security_builder_and_doc_improvements branch from b5c8d2e to 05b1685 Compare August 18, 2020 15:17
@gsmet
Copy link
Member

gsmet commented Aug 18, 2020

Do we agree that this should be backported?

@stuartwdouglas
Copy link
Member

+1 for back porting.

@gsmet gsmet merged commit c0d5f00 into quarkusio:master Aug 19, 2020
@gsmet gsmet added this to the 1.7.1.Final milestone Aug 24, 2020
@sberyozkin sberyozkin deleted the security_builder_and_doc_improvements branch September 16, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants