-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new builder identity copy method, reverse links to all security docs, client cert example #11446
Add a new builder identity copy method, reverse links to all security docs, client cert example #11446
Conversation
@gastaldi @loicmathieu @gsmet, your comments/reviews are also welcome :-), just would like to avoid formally asking 6 people to review :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
I'm not sure if this is enough to close the original issue. I don't feel strongly about adding a declarative way of extracting roles from a certificate -- it would be nice, but it's probably not that big of a deal, with documentation in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor documentation changes, otherwise looks good
docs/src/main/asciidoc/security-openid-connect-web-authentication.adoc
Outdated
Show resolved
Hide resolved
docs/src/main/asciidoc/security-openid-connect-web-authentication.adoc
Outdated
Show resolved
Hide resolved
Sure, lets keep the original issue open, the example in the docs would be useful on its own even if/when do something about that issue, as there could always be a situation where some custom certificate processing is required in order to enhance the identity |
@gastaldi Perfect editorial updates, thanks :-) |
… docs, client cert example
b5c8d2e
to
05b1685
Compare
Do we agree that this should be backported? |
+1 for back porting. |
This PR:
securty.doc
@Ladicek I'm not marking this PR as the one which provides a fix for #11434, if you think it can be sufficient at this stage then update it