Ignore modules with missing main source set #11374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/devtools
|
Failed tests are unrelated to my changes, do i see that right? |
glefloch
approved these changes
Aug 13, 2020
devtools/gradle/src/test/resources/multi-module-project/settings.gradle
Outdated
Show resolved
Hide resolved
|
Will it make it into 1.7.1? |
glefloch
reviewed
Aug 17, 2020
There was a problem hiding this comment.
LGTM, can you squash your commits? @aloubyansky WDYT? CI failures don't seem to be related.
ignore modules with javaConvention but no "main" sourceSets
|
Let's wait for the current CI to finish. |
aloubyansky
approved these changes
Aug 17, 2020
|
Thanks a lot @antonwiens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11370
i added a module to the multi-module test gradle project where the main source set gets deleted.
The test "shouldLoadMultiModuleModel" verifies that the module does not get added to the workspace
I also verified the build is working with my own project where it did previously not.