Introduce AutoAddScopeBuildItem to remove boilerplate necessary when annotation transformers are used to add a scope annotation to a class

[mkouba]

...annotation transformers are used to add a scope annotation to a class

• also fixes JSON-B type adapter can't inject CDI beans #11340

[gsmet]

It might be a stupid question and sorry if it's the case but should we also detect the lifecycle annotations? You might not have anything injected but a @PostConstruct?

[mkouba]

It's not a stupid question but I'm not sure all the specs support the lifecycle callbacks... In any case, we could add one more method to detect @PostConstruct and @PreDestroy.

[gsmet]

Well, that wouldn't hurt the ones that don't support it and would be nice for the ones that do? Or am I missing something?

[mkouba]

I get the point. We should rename the method then. It's only best effort anyway because even though we walk the class hierarchy we don't handle some special cases (e.g. an overriden initializer method)...

[mkouba]

Hm, what about requiresContainerServices()?

[manovotn]

Looks good, just one question.
It looks (maybe I am just missing something though) like this can lead to an erroneous state where you attempt to auto add scope but then later on ArC figures the given class is not a legal bean type. E.g. say it contains a wilcard.
I suppose in such case we blow up. Is that ok or should we add some checks for that?

[mkouba]

@manovotn Yes, it could blow up and even the current approach could blow up. Maybe we could add some check later. In any case, it would be easier to fix it in one place ;-).

[gsmet]

Very nice, let's get this in :).

[gsmet]

Formatting issue:

2020-08-13T09:09:12.9478980Z [ERROR] Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.12.1:validate (default) on project quarkus-scheduler-deployment: File '/home/runner/work/quarkus/quarkus/extensions/scheduler/deployment/src/main/java/io/quarkus/scheduler/deployment/SchedulerProcessor.java' has not been previously formatted.  Please format file and commit before running validation! -> [Help 1]
2020-08-13T09:09:12.9499182Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.12.1:validate (default) on project quarkus-scheduler-deployment: File '/home/runner/work/quarkus/quarkus/extensions/scheduler/deployment/src/main/java/io/quarkus/scheduler/deployment/SchedulerProcessor.java' has not been previously formatted.  Please format file and commit before running validation!

A mvn process-sources is in order!

[mkouba]

@gsmet Ah, damn -quickly again! Although I like the fact that Quarkus code is formatted automatically I don't like the current workflow :-(

[gsmet]

@mkouba could you check how much time it adds to enable the formatter with quickly?

[mkouba]

@gsmet I don't get consistent results on my laptop :-(. It's roughly 20 seconds (03:32 min VS 03:14 min) if no formatting changes are performed.

BTW those failures are CI problems again:

Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest'
Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'windows-latest'