Properly support subfolders for Flyway database migrations #11300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
approved these changes
Aug 10, 2020
gsmet
force-pushed
the
flyway-subfolder
branch
from
5d7655a to
c715ba3
Compare
|
This does not work in a Jar ! |
|
@rmanibus do you have a reproducer? If so, please open an issue and add it so we can fix this |
rmanibus
reviewed
Sep 1, 2020
| return pathStream.filter(Files::isRegularFile) | ||
| .map(it -> Paths.get(location, it.getFileName().toString()).toString()) | ||
| .map(it -> Paths.get(location, rootPath.relativize(it).toString()).toString()) |
There was a problem hiding this comment.
This does not work in a Jar !
I get unable to optain inputstream for resource:
db/migration/oracle/../oracle/<migration_name>.sql
with quarkus/flyway.locations=db/migration/oracle
There was a problem hiding this comment.
I will try to make a reproducer yes
There was a problem hiding this comment.
Please open a separate issue with a reproducer so that we can easily track it.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11288