Avoid including platform BOM twice in the Gradle plugin #11255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/devtools
gsmet
reviewed
Aug 6, 2020
...ools-common/src/main/java/io/quarkus/devtools/project/buildfile/AbstractGradleBuildFile.java
Outdated
Show resolved
Hide resolved
ia3andy
reviewed
Aug 6, 2020
...ools-common/src/main/java/io/quarkus/devtools/project/buildfile/AbstractGradleBuildFile.java
Show resolved
Hide resolved
gastaldi
added
the
triage/waiting-for-ci
|
I would like to have @aloubyansky 's blessing on this one so it will be merged for 1.7.1.Final. |
aloubyansky
reviewed
Aug 6, 2020
| // Check if BOM is not included already | ||
| String resolvedPlatform = String | ||
| .format("%s:%s", getProperty(model, "quarkusPlatformGroupId"), | ||
| getProperty(model, "quarkusPlatformArtifactId")); |
There was a problem hiding this comment.
It's better but works on the assumption that these properties are used. In general there could be any property or direct coordinates.
|
IMO, it's ok as a quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11251
Add test