Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codestart docker tooling error #11227

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Fix codestart docker tooling error #11227

merged 1 commit into from
Aug 5, 2020

Conversation

ia3andy
Copy link
Contributor

@ia3andy ia3andy commented Aug 5, 2020

Bug found by @survivant

@boring-cyborg boring-cyborg bot added the area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins label Aug 5, 2020
maxandersen
maxandersen approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are simply updating codestarts docker setup to the changes that have made it into 1.6/1.7 from before we started codestarts thus all good.

+1 LGTM and backported

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 5, 2020

@gsmet this will also need to be backported please

@gastaldi gastaldi merged commit 00188a2 into quarkusio:master Aug 5, 2020
@gsmet gsmet added this to the 1.7.0.Final milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxandersen maxandersen maxandersen approved these changes

Assignees
No one assigned
Labels
area/codestarts area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins
Projects
None yet
Milestone
1.7.0.Final
Development

Successfully merging this pull request may close these issues.
4 participants
@ia3andy @maxandersen @gastaldi @gsmet