Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - cleanup and optimizations #11217

Merged
merged 1 commit into from
Aug 6, 2020
Merged

ArC - cleanup and optimizations #11217

merged 1 commit into from
Aug 6, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Aug 5, 2020

  • AbstractSharedContext - replace Key with bean identifier
  • ComputingCache - add computeIfAbsent() methods
  • Generated beans implement equals()/hashCode() (based on bean
    identifier)
  • fail fast if multiple synthetic beans have the same bean identifier

@mkouba mkouba added the area/arc Issue related to ARC (dependency injection) label Aug 5, 2020
@mkouba mkouba added this to the 1.8.0 - master milestone Aug 5, 2020
@mkouba mkouba requested a review from manovotn August 5, 2020 06:55
@mkouba
Copy link
Contributor Author

mkouba commented Aug 5, 2020

This is a follow-up of #11148.

CC @bcluap @gsmet @loicmathieu

@mkouba mkouba mentioned this pull request Aug 5, 2020
Closed
@mkouba
Copy link
Contributor Author

mkouba commented Aug 5, 2020

Looks like a CI infra failure again:

2020-08-05T07:18:42.4711056Z ##[section]Starting: Request a runner to run this job
2020-08-05T07:18:43.2577136Z Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest'
2020-08-05T07:18:43.2577264Z Can't find any online and idle self-hosted runner in current repository's account/organization that matches the required labels: 'ubuntu-latest'
2020-08-05T07:18:43.2577325Z Found online and idle hosted runner in current repository's account/organization that matches the required labels: 'ubuntu-latest'
2020-08-05T07:18:43.5020755Z ##[section]Finishing: Request a runner to run this job

gsmet
gsmet requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small things to discuss.

independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanDeployment.java Show resolved Hide resolved
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/BeanGenerator.java Outdated Show resolved Hide resolved
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/ComputingCache.java Outdated Show resolved Hide resolved
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/AbstractSharedContext.java Outdated Show resolved Hide resolved
@mkouba
ArC - cleanup and optimizations
98b0e65 
- AbstractSharedContext - replace Key with bean identifier
- ComputingCache - add computeIfAbsent() methods
- Generated beans implement equals()/hashCode() (based on bean
identifier)
- fail fast if multiple synthetic beans have the same bean identifier
@mkouba mkouba force-pushed the shared-context-opt branch from edb0135 to 98b0e65 Compare August 5, 2020 11:09
@mkouba mkouba requested a review from gsmet August 5, 2020 11:10
@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Aug 5, 2020
@mkouba
Copy link
Contributor Author

mkouba commented Aug 6, 2020

It's Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest' again... @gsmet should we merge?

@gsmet
Copy link
Member

gsmet commented Aug 6, 2020

Yeah, the JVM 14 build is failing consistently now, I don't know why. Will try to have a look this afternoon.

@gsmet gsmet merged commit 93b6970 into quarkusio:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.8.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkouba @gsmet @manovotn