Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for incorrect .equals checks #11178

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Fixes for incorrect .equals checks #11178

merged 2 commits into from
Aug 4, 2020

Conversation

rsvoboda
Copy link
Member

@rsvoboda rsvoboda commented Aug 3, 2020

Fixes for incorrect .equals checks - comparing incompatible types for equality

  • Classifier is optional, equality check needs to reflect that
  • Capability is enum, not String

@mkouba please check my code changes

@rsvoboda rsvoboda requested a review from mkouba August 3, 2020 19:57
@boring-cyborg boring-cyborg bot added area/arc Issue related to ARC (dependency injection) area/kubernetes labels Aug 3, 2020
mkouba
mkouba approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mkouba mkouba added this to the 1.8.0 - master milestone Aug 4, 2020
@mkouba mkouba merged commit edda12b into quarkusio:master Aug 4, 2020
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.0.CR2 Aug 4, 2020
@rsvoboda rsvoboda deleted the irrelevant.equals branch March 4, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/kubernetes
Projects
None yet
Milestone
1.7.0.CR2
Development

Successfully merging this pull request may close these issues.
3 participants
@rsvoboda @mkouba @gsmet