Upgrade to Hibernate Search 6.0.0.Beta9 + Elasticsearch 7.8 #11166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area/dependencies
10 tasks
gsmet
reviewed
Aug 3, 2020
| // There is at least one named backend: we disallow using the default backend. | ||
| // Theoretically we could allow using it, | ||
| // but then we would be unable to detect whether the default backend is used | ||
| // (and thus absolutely needs the version to be configured) |
There was a problem hiding this comment.
Not sure I follow you here. We make the version mandatory for named backend so maybe we should just make it mandatory for everything, default backend included? And then we could keep the named backend active?
There was a problem hiding this comment.
If we do that, then people using named backends exclusively (which, IMO, is what they should do if they have multiple backends) will have to set the version for the default backend even if they don't use it. I can do that if you want, but I'm not sure it's a better solution.
There was a problem hiding this comment.
I fixed this according to our discussion on Zulip, rebased and force-pushed. Let's wait for CI, but then as far as I know it can be merged.
...uarkus/hibernate/search/elasticsearch/runtime/HibernateSearchElasticsearchRuntimeConfig.java
Outdated
Show resolved
Hide resolved
|
I had a quick look at the build failure, and it seems unrelated. I suspect a problem on master? |
|
@gsmet Also, for the migration guide: |
|
@gsmet should I do anything or is it ok to merge ? |
… instead of defining our own
This feature probably wasn't used a lot by Quarkus users, since it's only (potentially) useful when you have multiple backends.
…fault configuration for indexes
…ifying default configuration for indexes
I had renamed the tests in 961d95b because I misunderstood their purpose from the comment on IndexedEntity and thought they were misnamed, but actually it's the comment that was unclear and should have been fixed.
yrodiere
force-pushed
the
hsearch-6-beta9
branch
from
d908226 to
2e6f816
Compare
gsmet
reviewed
Aug 20, 2020
...uarkus/hibernate/search/elasticsearch/runtime/HibernateSearchElasticsearchRuntimeConfig.java
Show resolved
Hide resolved
gsmet
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant: https://in.relation.to/2020/08/03/hibernate-search-6-0-0-Beta9/