-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldap mock: using random port instead of hardcoded one #11140
ldap mock: using random port instead of hardcoded one #11140
Conversation
Thanks a lot for the contribution! Would you like to explain what use case you are trying to solve with this? |
I just think it's cleaner code to use a random port instead of a hardcoded one. And one does not have to manually set the quarkus.security.ldap.dir-context.url when using the LdapTestResource. |
We don't really do this for other things, so I am kind of against this. @gastaldi WDYT? |
@geoand I don't have a strong opinion about this but given that this is used in tests and that the necessary parameters to run the tests are set in the LdapTestResource, I think that kinda makes sense. Perhaps we should adapt our other tests to run in random ports in order to facilitate parallel testing |
we already do 8081 instead of 8080 for testing to run while products; I agree with @gastaldi it would be interesting to see what we can do to ensure parallel tests and less fricition in test setup is feasible. |
I don't know if random is the right approach - but I assume there gotta be many more examples of things like this ? |
Random enables parallel tests compared to a fixed port, so I think it makes sense |
We should look at enabling random ports in our HTTP tests, I think there is an issue asking for that already |
Go for it! |
Merged, thanks! |
No description provided.