Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use -Xverify:none on Java 13+ in dev mode #11120

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Don't use -Xverify:none on Java 13+ in dev mode #11120

merged 1 commit into from
Jul 31, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 31, 2020 •
edited
Loading

This is done because the flag has been deprecated from Java 13
onward and its use results in:

OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify
were deprecated in JDK 13 and will likely be removed in a future release.

@geoand
Don't use Xverify:none on Java 13+ in dev mode
1d754b2 
This is done because the flag has been deprecated from Java 13
onward and its use results in:

```
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify
were deprecated in JDK 13 and will likely be removed in a future release.
```
@geoand geoand requested a review from stuartwdouglas July 31, 2020 09:28
@boring-cyborg boring-cyborg bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Jul 31, 2020
@geoand geoand changed the title Don't use Xverify:none on Java 13+ in dev mode Don't use -Xverify:none on Java 13+ in dev mode Jul 31, 2020
@geoand
Copy link
Contributor Author

geoand commented Jul 31, 2020

CI failures are totally unrelated with this PR

gastaldi
gastaldi approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet merged commit 5694012 into quarkusio:master Jul 31, 2020
@gsmet gsmet added this to the 1.8.0 - master milestone Jul 31, 2020
@geoand geoand deleted the devmode-verify branch August 3, 2020 05:08
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.0.CR2 Aug 4, 2020
@famod famod mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven
Projects
None yet
Milestone
1.7.0.CR2
Development

Successfully merging this pull request may close these issues.
3 participants
@geoand @gastaldi @gsmet