Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change security annotations to use recorders #11112

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Change security annotations to use recorders #11112

merged 1 commit into from
Jul 31, 2020

Conversation

stuartwdouglas
Copy link
Member

Recorders automatically break up large methods

Fixes #11075

@stuartwdouglas
Change security annotations to use recorders
514d0e1 
Recorders automatically break up large methods

Fixes quarkusio#11075
@boring-cyborg boring-cyborg bot added area/security area/spring Issues relating to the Spring integration labels Jul 31, 2020
@stuartwdouglas stuartwdouglas requested a review from geoand July 31, 2020 01:21
gastaldi
gastaldi approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi gastaldi added this to the 1.8.0 - master milestone Jul 31, 2020
geoand
geoand approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Not only does it fix an issue that we were bound to run into at some point, but it also gets rid of a lot of bytecode generation, 👍 👍 👍

@gsmet gsmet merged commit 4c99b94 into quarkusio:master Jul 31, 2020
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.0.CR1 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/security area/spring Issues relating to the Spring integration
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Large numbers of security annotations will cause deployment to fail
4 participants
@stuartwdouglas @gastaldi @geoand @gsmet