Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NativeImageBuild: Add --user flag to podman #11100

Merged
merged 1 commit into from
Jul 30, 2020
Merged

NativeImageBuild: Add --user flag to podman #11100

merged 1 commit into from
Jul 30, 2020

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Jul 30, 2020

Closes #10637

@zakkak
Copy link
Contributor Author

zakkak commented Jul 30, 2020

@rsvoboda could you please give this a spin?

gastaldi
gastaldi approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gastaldi
Copy link
Contributor

Waiting on @rsvoboda's feedback before merging

@gastaldi gastaldi requested a review from rsvoboda July 30, 2020 15:43
@gastaldi gastaldi added this to the 1.8.0 - master milestone Jul 30, 2020
@gastaldi
Copy link
Contributor

I've reproduced the problem with 1.6.1.Final. I just tested locally and I can confirm that this PR fixes the issue.

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 30, 2020
@gsmet
Copy link
Member

gsmet commented Jul 30, 2020

Thanks @gastaldi!

@gsmet gsmet merged commit 3b82e59 into quarkusio:master Jul 30, 2020
@gsmet
Copy link
Member

gsmet commented Jul 30, 2020

Nice work @zakkak !

@zakkak zakkak deleted the fix-10637 branch July 30, 2020 20:14
@geoand
Copy link
Contributor

geoand commented Jul 30, 2020

Great, thanks!

@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.0.CR1 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@rsvoboda rsvoboda Awaiting requested review from rsvoboda

Assignees
No one assigned
Labels
area/core triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Quarkus NativeImageBuildStep fails with perm denied with podman 2.x
4 participants
@zakkak @gastaldi @gsmet @geoand