Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print the URL where the Openshift application can be found #11090

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Print the URL where the Openshift application can be found #11090

merged 1 commit into from
Jul 30, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 30, 2020

@geoand geoand requested a review from iocanel July 30, 2020 10:01
@geoand geoand force-pushed the openshift-route-print branch from bf1b9ee to e8f4165 Compare July 30, 2020 11:11
@geoand geoand marked this pull request as ready for review July 30, 2020 13:11
@geoand geoand requested a review from Ladicek July 30, 2020 13:11
@geoand geoand added this to the 1.7.0.Final milestone Jul 30, 2020
iocanel
iocanel approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@iocanel
Copy link
Contributor

iocanel commented Jul 30, 2020

At some point we need to do the equivalent for minikube.

@geoand
Copy link
Contributor Author

geoand commented Jul 30, 2020

Indeed!

@geoand geoand added triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jul 30, 2020
@gsmet gsmet removed this from the 1.7.0.Final milestone Jul 30, 2020
@gastaldi gastaldi added this to the 1.8.0 - master milestone Jul 30, 2020
@gastaldi gastaldi merged commit 38712a3 into quarkusio:master Jul 30, 2020
@gastaldi gastaldi deleted the openshift-route-print branch July 30, 2020 17:17
@gsmet gsmet modified the milestones: 1.8.0 - master, 1.7.0.CR1 Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@iocanel iocanel iocanel approved these changes

Assignees
No one assigned
Labels
area/kubernetes triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
5 participants
@geoand @iocanel @Ladicek @gastaldi @gsmet