Add quarkus table prefix prop #11074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
requested changes
Jul 30, 2020
| * Optional - defaults to `QRTZ_` if not specified. | ||
| * Ignored if using a `ram` store. | ||
| */ | ||
| @ConfigItem |
There was a problem hiding this comment.
Minor but you should use defaultValue = "QRTZ_" in this annotation.
This has several advantages: you can drop the doc about the default value above and it being optional: it will be automatically documented. You can also simplify the configuration code below.
There was a problem hiding this comment.
Pushed changes - thank you for the review!
|
Thanks! If you can get my comment applied soon, I'll try to get that one into 1.7.0.CR1 that I release today. |
cpowicki
force-pushed
the
quartz-table-prefix-prop
branch
from
b81ca11 to
1c4e41a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to optionally set the
org.quartz.jobStore.tablePrefix(quartz docs here) config property, as opposed to hardcoding 'QRTZ'.This is useful for situations where there are multiple schedulers that need to use different sets of tables.