Go back to previous behavior regarding Surefire and Maven IT

[gsmet]

Follow up of #10919

We better get back to the previous behavior which was to never run the plugin rather than introducing some change in this area.

Remember when I said this whole native surefire skip thing was a bad idea?

[famod]

Trying to make sense of it (and learn something): What did I break exactly?

[gsmet]

So you didn't break something, it's just that the original intent (the part you removed) was to always disable the surefire tests. And the new part you kept can have them enabled. I just got back to the original intent.

You had one chance out of two :).

[famod]

Ok, understood.

I did not follow the PR in detail that introduced ${native.surefire.skip} but I knew that it was merged before, so the block I removed felt like a leftover. 🤷‍♂️

It would certainly be helpful if there was a short comment right over or next to this line clarifying the intent (since it not appears to be clear to everyone). This might help to prevent the next thoughtless bypasser from making the same mistake. 😉

[gsmet]

TBH, I have no idea why it was there. I just don't think we should change the behavior with something that is orthogonal.

(and I won't spend more time on this as I was against the initial patch)