Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the building native image doc #10997

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 27, 2020

The idea is to help users understand the difference between

quarkus.native.container-build=true

and

quarkus.container-image.build=true

Fixes: #10984

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some minor gripes.

docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/building-native-image.adoc Outdated Show resolved Hide resolved
The idea is to help users understand the difference between
-Dquarkus.native.container-build=true
and
-Dquarkus.container-image.build=true

Fixes: quarkusio#10984

Co-authored-by: Guillaume Smet <[email protected]>
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsmet gsmet added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 27, 2020
@machi1990 machi1990 merged commit 6711692 into quarkusio:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NativeImageBuildStep fails if 'docker' is not installed
4 participants