Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace vertx-stack-depchain with vertx-dependencies #10993

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

michalszynkiewicz
Copy link
Member

@michalszynkiewicz michalszynkiewicz commented Jul 27, 2020

Currently we import vetrx-stack-depchain. vertx-stack-depchain's parent imports vertx-dependencies. This way we implicitly import vertx-dependencies.

This PR changes the import to vertx-dependencies to cut out the middleman

@boring-cyborg boring-cyborg bot added the area/dependencies Pull requests that update a dependency file label Jul 27, 2020
@gsmet
Copy link
Member

gsmet commented Jul 27, 2020

Was it discussed with @cescoffier ? Because he's on PTO for a while and I'm not comfortable merging this without his blessing.

@michalszynkiewicz
Copy link
Member Author

Clement thought of listing the dependencies from vertx-stack-depchain excplicitly in our bom, not to depend on vertx-dependencies at all.
We can probably get it in 1.7.1, let's wait for Clement

@gsmet
Copy link
Member

gsmet commented Jul 27, 2020

It's either in CR1 or not in 1.7.

I really don't want to take any risk regarding that post CR1.

And IIRC, Clément is on PTO for 3 weeks.

@gsmet gsmet added the triage/on-ice Frozen until external concerns are resolved label Jul 28, 2020
@cescoffier
Copy link
Member

We can proceed with that change.
Even if I'm not a big fan of using the "internal" BOM it's the one productized.

If it simplifies productization go for it.
The other solution would be to not use any BOM, which would avoid having users to rely on unsupported Vert.x modules but introduce version dilemma.

That being said... would prefer a rebase first :-)

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated by Clément.

@gsmet gsmet added this to the 1.8.0 - master milestone Aug 27, 2020
@gsmet gsmet merged commit 1db06d0 into quarkusio:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file triage/on-ice Frozen until external concerns are resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants