Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding OpenAPI in the Reactive Routes Guide #10980

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Adding OpenAPI in the Reactive Routes Guide #10980

merged 1 commit into from
Jul 28, 2020

Conversation

phillip-kruger
Copy link
Member

@phillip-kruger phillip-kruger commented Jul 27, 2020 •
edited
Loading

This PR adds the OpenAPI section to the Reactive Routes Guide. (see PR #10944)

It also updates to the latest SmallRye OpenAPI version that contains some more fixes for the Reactive Routes, namely

  • Support for default method on a Route (GET)
  • Support for default path on a Route (Method Name)

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/documentation area/smallrye labels Jul 27, 2020
@phillip-kruger phillip-kruger requested a review from mkouba July 27, 2020 07:07
@mkouba
Copy link
Contributor

mkouba commented Jul 27, 2020

Support for default method on a Route (GET)

Hm, if a route specifies no method then all methods are assumed. This is the default behavior from vertx-web.

@phillip-kruger
Copy link
Member Author

phillip-kruger commented Jul 27, 2020 •
edited
Loading

Ok, can I add the others in the next version of smallrye ? I opened a ticket there: smallrye/smallrye-open-api#416

@phillip-kruger phillip-kruger requested a review from mkouba July 27, 2020 08:13
mkouba
mkouba approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jul 27, 2020
gsmet
gsmet requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some very minor suggestions. If you can apply them and squash, that would be great.

docs/src/main/asciidoc/reactive-routes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-routes.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/reactive-routes.adoc Outdated Show resolved Hide resolved
@phillip-kruger phillip-kruger requested a review from gsmet July 27, 2020 13:35
@gsmet gsmet merged commit a045b8b into quarkusio:master Jul 28, 2020
@gsmet
Copy link
Member

gsmet commented Jul 28, 2020

Merged, thanks!

@gsmet gsmet added this to the 1.7.0 - master milestone Jul 28, 2020
@phillip-kruger phillip-kruger deleted the documentation-update-openapi branch July 28, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@mkouba mkouba mkouba approved these changes

Assignees
No one assigned
Labels
area/dependencies Pull requests that update a dependency file area/documentation area/smallrye triage/waiting-for-ci Ready to merge when CI successfully finishes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@phillip-kruger @mkouba @gsmet