Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote Dev Fixes #10977

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Remote Dev Fixes #10977

merged 2 commits into from
Jul 27, 2020

Conversation

stuartwdouglas
Copy link
Member

  • Don't fail the build if dev mode kube manifest generation fails
  • Don't add the pre scan step multiple times

@stuartwdouglas
If kube generation fails in dev mode don't fail the build
c09f1ff 
Remote-dev mode does not have a project present.

We really need something better so there is no exception,
but this should probably be non-fatal in dev mode anyway.

Fixes quarkusio#10975
@stuartwdouglas
Only register pre-scan step once
43da52e 
This was being registered on overy restart,
which was causing problems

Fixes quarkusio#10969
@geoand geoand merged commit 3747a78 into quarkusio:master Jul 27, 2020
@geoand geoand added this to the 1.7.0 - master milestone Jul 27, 2020
@geoand geoand mentioned this pull request Jul 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/kubernetes area/vertx
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartwdouglas @geoand