Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that minikube manifests have all env vars #10926

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Make sure that minikube manifests have all env vars #10926

merged 1 commit into from
Jul 23, 2020

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jul 23, 2020

Fixes: #10925

@geoand geoand requested a review from iocanel July 23, 2020 07:07
@geoand geoand added this to the 1.7.0 - master milestone Jul 23, 2020
@geoand geoand requested a review from gastaldi July 23, 2020 13:11
gastaldi
gastaldi approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoand geoand merged commit 7fc6af5 into quarkusio:master Jul 23, 2020
@geoand geoand deleted the #10925 branch July 23, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
area/kubernetes
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Kubernetes extension doesn't properly populate env vars for Minikube
2 participants
@geoand @gastaldi