enable gradle grpc devmode test #10906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,11 +19,11 @@ test { | |||
| forkEvery 1 | |||
| } | |||
|
|
|||
| quarkusDev { | |||
| quarkusPrepare { | |||
There was a problem hiding this comment.
@glefloch could you explain to me what this change does?
There was a problem hiding this comment.
before we were specifying that quarkusDev must be run after the publish (or install) of the runtime and deployment module of this project.
Since quarkusPrepare is run before quarkusDev but needs these dependencies to build the AppModel, I change this to make the quarkusPrepare depends on the publish of the required module (which are not always dependencies like for the deploymentmodule)
michalszynkiewicz
approved these changes
Jul 22, 2020
aloubyansky
approved these changes
Jul 22, 2020
|
thanks a lot @glefloch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch enable
quarkusPreparetask as a dependency ofquarkusDev. The only error was due to a missing dependency in a test.Making
quarkusPrepareinstead ofquarkusDevdepends on the task in charge of publishing that dependency locally, fix the test.close #10631