gRPC code gen to generate health and reflection stubs #10886
Conversation
boring-cyborg
bot
added
the
area/dependencies
michalszynkiewicz
added
the
triage/waiting-for-ci
| if (OS.determineOS() == OS.LINUX) { | ||
| return path.replaceAll(" ", "\\ "); | ||
| } else { | ||
| return path; |
There was a problem hiding this comment.
spaces will work as is on Windows and macOS?
There was a problem hiding this comment.
I don't know, I don't really have a way to check.
@rsvoboda reported that it doesn't work on linux
There was a problem hiding this comment.
To shed some more light on it, the paths are passed as separate arguments in the ProcessBuilder's command, so they should be okay without backslashes before spaces. It's protoc that doesn't handle them properly on Linux. I don't know about other systems.
There was a problem hiding this comment.
Maybe @cescoffier can check on macOS if you can put together a test case?
There was a problem hiding this comment.
@cescoffier checked and this version (without \ before spaces) worked for him on Mac
michalszynkiewicz
removed
the
triage/waiting-for-ci
michalszynkiewicz
force-pushed
the
code-gen-everywhere
branch
from
f829066 to
5964ae0
Compare
michalszynkiewicz
force-pushed
the
code-gen-everywhere
branch
from
5964ae0 to
3ecb368
Compare
|
I updated the doc by the way |
| if (OS.determineOS() == OS.LINUX) { | ||
| return path.replaceAll(" ", "\\ "); | ||
| } else { | ||
| return path; |
There was a problem hiding this comment.
Maybe @cescoffier can check on macOS if you can put together a test case?
michalszynkiewicz
force-pushed
the
code-gen-everywhere
branch
from
160c7bc to
bbb79f1
Compare
boring-cyborg
bot
added
area/core
area/devtools
fixes #10214