Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive routes - handle RC.getBodyAsJson() returning null correctly #10871

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Reactive routes - handle RC.getBodyAsJson() returning null correctly #10871

merged 2 commits into from
Jul 21, 2020

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jul 21, 2020

@mkouba
Reactive routes - handle RC.getBodyAsJson() returning null correctly
80db54d 
- also share the failure callback class for all routes returning Uni
- resolves quarkusio#10858
@mkouba mkouba added this to the 1.7.0 - master milestone Jul 21, 2020
@mkouba mkouba requested a review from cescoffier July 21, 2020 07:05
@mkouba
Copy link
Contributor Author

mkouba commented Jul 21, 2020

@cescoffier Pls review, we need this to be merged before I send a PR to improve the existing hibernate reactive routes quickstart...

@mkouba mkouba mentioned this pull request Jul 21, 2020
Merged
@cescoffier cescoffier merged commit e8b0e4b into quarkusio:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/reactive area/vertx
Projects
None yet
Milestone
1.7.0.CR1
Development

Successfully merging this pull request may close these issues.

Reactive routes - io.vertx.ext.web.RoutingContext.getBodyAsJson() may return null
2 participants
@mkouba @cescoffier