Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for Avro in native mode. #10830

Merged
merged 1 commit into from
Jul 20, 2020

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Jul 18, 2020

This PR adds experimental support for Avro in native mode.

I consider this support experimental as I based my experiments on the few tests we have. So most probably something might be missing, or need to be tuned.

The PR introduced a new quarkus-avro extension with a few substitutions and native configuration.
It also extends the Kafka Processor to register the Avro serde and related classes for the Confluent Avro serde and the Apicurio Avro serde.

This might also enable Avro for Kafka Streams (CC @gunnarmorling)

@boring-cyborg boring-cyborg bot added area/dependencies Pull requests that update a dependency file area/kafka labels Jul 18, 2020
@cescoffier cescoffier force-pushed the features/avro-native branch from 9cdbf9e to b9485a9 Compare July 18, 2020 17:36
@cescoffier cescoffier force-pushed the features/avro-native branch from b9485a9 to 5c68f82 Compare July 19, 2020 06:05
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I added a small question. Feel free to merge if it was intentional.

metadata:
keywords:
- "avro"
guide: "https://quarkus.io/guides/kafka"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing to the Kafka guide is intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Avro is mostly uses with Kafka. So far it's the only usage we have.

@cescoffier cescoffier merged commit beceadd into quarkusio:master Jul 20, 2020
@cescoffier cescoffier added this to the 1.7.0 - master milestone Jul 20, 2020
@cescoffier cescoffier deleted the features/avro-native branch July 23, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/kafka
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants